Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): ui parts service support more generic situations #2286

Merged
merged 1 commit into from
May 21, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented May 21, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 30.20%. Comparing base (b253997) to head (920f830).

Files Patch % Lines
packages/ui/src/services/parts/parts.service.ts 0.00% 9 Missing ⚠️
...s/sheets-ui/src/controllers/sheet-ui.controller.ts 0.00% 3 Missing ⚠️
...kages/docs-ui/src/controllers/doc-ui.controller.ts 0.00% 1 Missing ⚠️
...s-formula/src/controllers/formula-ui.controller.ts 0.00% 1 Missing ⚠️
...s/slides-ui/src/controllers/slide-ui.controller.ts 0.00% 1 Missing ⚠️
...ui/src/services/confirm/desktop-confirm.service.ts 0.00% 1 Missing ⚠️
...s/ui/src/services/dialog/desktop-dialog.service.ts 0.00% 1 Missing ⚠️
...vices/notification/desktop-notification.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2286      +/-   ##
==========================================
- Coverage   30.20%   30.20%   -0.01%     
==========================================
  Files        1413     1413              
  Lines       72491    72493       +2     
  Branches    15155    15155              
==========================================
  Hits        21897    21897              
- Misses      50594    50596       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 21, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev wzhudev merged commit 415d5b8 into dev May 21, 2024
9 checks passed
@wzhudev wzhudev deleted the feat/ui-parts-service branch May 21, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants