Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): active next sheet when remove sheet #2305

Merged
merged 2 commits into from
May 24, 2024
Merged

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented May 23, 2024

如何测试?

删除第一个sheet,会切换到第二个sheet。原来不会。

  • fix active next sheet when remove sheet
  • add i18n for formula type

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label May 23, 2024
@univer-bot
Copy link

univer-bot bot commented May 23, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Origin Title: fix(sheet): active next sheet when remove sheet

Title: fix(sheet): active next sheet when remove sheet


如何测试?

删除第一个sheet,会切换到第二个sheet。原来不会。

  • fix active next sheet when remove sheet
  • add i18n for formula type

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented May 23, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dushusir Dushusir force-pushed the dushusir/formula-panel branch from c94f108 to 5282df8 Compare May 24, 2024 03:10
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.16%. Comparing base (a5a7b33) to head (5282df8).
Report is 5 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2305   +/-   ##
=======================================
  Coverage   30.16%   30.16%           
=======================================
  Files        1418     1418           
  Lines       72588    72588           
  Branches    15207    15207           
=======================================
+ Hits        21893    21895    +2     
+ Misses      50695    50693    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label May 24, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label May 24, 2024
@Dushusir Dushusir merged commit 9a24216 into dev May 24, 2024
9 checks passed
@Dushusir Dushusir deleted the dushusir/formula-panel branch May 24, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants