Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: underline in sheet cell #2306

Merged
merged 3 commits into from
May 27, 2024
Merged

fix: underline in sheet cell #2306

merged 3 commits into from
May 27, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented May 23, 2024

close https://github.com/dream-num/univer-pro/issues/668

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 30.06%. Comparing base (0144179) to head (1c452a5).

Files Patch % Lines
...gine-render/src/components/docs/extensions/line.ts 0.00% 23 Missing ⚠️
packages/engine-render/src/context.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2306   +/-   ##
=======================================
  Coverage   30.06%   30.06%           
=======================================
  Files        1421     1421           
  Lines       73103    73106    +3     
  Branches    15316    15316           
=======================================
+ Hits        21975    21976    +1     
- Misses      51128    51130    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 23, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Jocs Jocs marked this pull request as ready for review May 24, 2024 03:56
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label May 24, 2024
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label May 27, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label May 27, 2024
@Jocs Jocs merged commit 5c6b010 into dev May 27, 2024
9 checks passed
@Jocs Jocs deleted the fix/cell-underline branch May 27, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants