Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(drawing): sheets and docs drawing #2324

Merged
merged 106 commits into from
May 31, 2024
Merged

feat(drawing): sheets and docs drawing #2324

merged 106 commits into from
May 31, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented May 25, 2024

  • float image
  • cell image
  • drawing

Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 2.71415% with 5054 lines in your changes are missing coverage. Please review.

Project coverage is 27.68%. Comparing base (da8b06b) to head (7da608d).
Report is 2 commits behind head on dev.

Files Patch % Lines
...ers/sheet-drawing-transform-affected.controller.ts 0.00% 620 Missing ⚠️
packages/engine-render/src/scene.transformer.ts 0.00% 610 Missing ⚠️
...ng-ui/src/controllers/drawing-update.controller.ts 0.00% 392 Missing ⚠️
...es/drawing/src/services/drawing-manager.service.ts 0.00% 379 Missing ⚠️
...ing-ui/src/controllers/image-cropper.controller.ts 0.00% 240 Missing ⚠️
...wing-ui/src/controllers/image-update.controller.ts 0.00% 179 Missing ⚠️
...es/drawing-ui/src/views/panel/DrawingTransform.tsx 0.00% 179 Missing ⚠️
...src/controllers/sheet-drawing-update.controller.ts 0.00% 158 Missing ⚠️
...i/src/controllers/doc-drawing-update.controller.ts 0.00% 151 Missing ⚠️
packages/engine-render/src/shape/image.ts 0.00% 146 Missing ⚠️
... and 127 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2324      +/-   ##
==========================================
- Coverage   29.25%   27.68%   -1.57%     
==========================================
  Files        1516     1605      +89     
  Lines       76736    81080    +4344     
  Branches    15942    16804     +862     
==========================================
+ Hits        22447    22448       +1     
- Misses      54289    58632    +4343     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 25, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@DR-Univer DR-Univer requested a review from wzhudev May 29, 2024 07:57
@DR-Univer DR-Univer requested a review from siam-ese as a code owner May 29, 2024 17:58
@DR-Univer DR-Univer merged commit 4853425 into dev May 31, 2024
9 checks passed
@DR-Univer DR-Univer deleted the feat/drawing-docs-2 branch May 31, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants