Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): observer remove unregisterOnNextCall #2334

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented May 28, 2024

How to test?

const activeSheet = univerAPI.getActiveWorkbook()?.getActiveSheet();
univerAPI.getSheetHooks().onCellDrop((cell) => {
    console.log('onCellDrop', cell);
    if (cell?.location.row !== undefined && cell?.location.col !== undefined) {
        const range = activeSheet?.getRange(cell?.location.row, cell?.location.col, 1, 1);
        if (range) {
            range.setValue('Dropped');
        }
    }
});

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 30.15%. Comparing base (5cc6881) to head (6532216).

Files Patch % Lines
packages/slides/src/views/render/canvas-view.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2334      +/-   ##
==========================================
+ Coverage   30.05%   30.15%   +0.10%     
==========================================
  Files        1421     1421              
  Lines       73107    73076      -31     
  Branches    15317    15308       -9     
==========================================
+ Hits        21975    22039      +64     
+ Misses      51132    51037      -95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 28, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Dushusir Dushusir merged commit 5c4f479 into dev May 28, 2024
9 checks passed
@Dushusir Dushusir deleted the dushusir/observer-bug branch May 28, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants