Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: storybook failed because can not override name property #2339

Merged
merged 2 commits into from
May 28, 2024
Merged

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented May 28, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Jocs Jocs marked this pull request as ready for review May 28, 2024 12:30
@Jocs Jocs requested a review from wzhudev as a code owner May 28, 2024 12:30
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label May 28, 2024
@Jocs Jocs removed the qa:untested This PR is ready to be tested label May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.23%. Comparing base (09fd989) to head (4b5ca97).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2339      +/-   ##
==========================================
- Coverage   29.24%   29.23%   -0.02%     
==========================================
  Files        1515     1515              
  Lines       76673    76672       -1     
  Branches    15916    15916              
==========================================
- Hits        22424    22412      -12     
- Misses      54249    54260      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 28, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Jocs Jocs merged commit 5853999 into dev May 28, 2024
9 checks passed
@Jocs Jocs deleted the fix/storybook branch May 28, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants