Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(network): fix http type #2359

Merged
merged 2 commits into from
May 30, 2024
Merged

fix(network): fix http type #2359

merged 2 commits into from
May 30, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented May 30, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 29.23%. Comparing base (07e0ebb) to head (08fea5a).

Files Patch % Lines
packages/network/src/services/http/http.service.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2359      +/-   ##
==========================================
- Coverage   29.24%   29.23%   -0.01%     
==========================================
  Files        1515     1515              
  Lines       76707    76711       +4     
  Branches    15932    15933       +1     
==========================================
  Hits        22430    22430              
- Misses      54277    54281       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 30, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev wzhudev merged commit fe3ac1d into dev May 30, 2024
9 checks passed
@wzhudev wzhudev deleted the fix/http-type branch May 30, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant