Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimization of doc image #2432

Merged
merged 101 commits into from
Jul 11, 2024
Merged

feat: optimization of doc image #2432

merged 101 commits into from
Jul 11, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Jun 5, 2024

close https://github.com/dream-num/univer-pro/issues/1101

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Jocs Jocs force-pushed the feat/optimization-doc-image branch from f976926 to 444e1c2 Compare June 5, 2024 13:07
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 1.60714% with 1653 lines in your changes missing coverage. Please review.

Project coverage is 25.91%. Comparing base (ce887b0) to head (2230d3a).
Report is 8 commits behind head on dev.

Files Patch % Lines
...llers/doc-drawing-transformer-update.controller.ts 0.00% 378 Missing ⚠️
...rc/commands/commands/update-doc-drawing.command.ts 0.00% 270 Missing ⚠️
...i/src/views/doc-image-panel/DocDrawingPosition.tsx 0.00% 161 Missing ⚠️
...i/src/views/doc-image-panel/DocDrawingTextWrap.tsx 0.00% 121 Missing ⚠️
...controllers/doc-drawing-notification.controller.ts 0.00% 113 Missing ⚠️
...kages/docs/src/commands/commands/delete.command.ts 0.00% 82 Missing ⚠️
...rollers/doc-drawing-transform-update.controller.ts 0.00% 71 Missing ⚠️
...ontrollers/doc-drawing-update.render-controller.ts 0.00% 59 Missing ⚠️
...onents/docs/layout/block/paragraph/layout-ruler.ts 0.00% 59 Missing ⚠️
...rc/commands/commands/remove-doc-drawing.command.ts 0.00% 42 Missing ⚠️
... and 31 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2432      +/-   ##
==========================================
- Coverage   26.23%   25.91%   -0.33%     
==========================================
  Files        1684     1691       +7     
  Lines       89226    90602    +1376     
  Branches    18798    19121     +323     
==========================================
+ Hits        23407    23475      +68     
- Misses      65819    67127    +1308     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 5, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Jocs Jocs force-pushed the feat/optimization-doc-image branch 5 times, most recently from 94940cc to 03ac12a Compare June 7, 2024 15:05
@Jocs Jocs force-pushed the feat/optimization-doc-image branch 2 times, most recently from 1333ffe to efc11dc Compare June 19, 2024 03:46
@Jocs Jocs marked this pull request as ready for review June 19, 2024 09:05
@Jocs Jocs added the qa:untested This PR is ready to be tested label Jun 19, 2024
@Jocs Jocs force-pushed the feat/optimization-doc-image branch 3 times, most recently from f440374 to 49471f6 Compare June 22, 2024 02:25
@Jocs Jocs force-pushed the feat/optimization-doc-image branch 2 times, most recently from b4cefe4 to f66ed98 Compare July 5, 2024 03:14
@Jocs Jocs requested a review from Dushusir as a code owner July 5, 2024 03:14
@Jocs Jocs force-pushed the feat/optimization-doc-image branch 3 times, most recently from ce8970b to c8950a3 Compare July 6, 2024 04:04
@Gggpound Gggpound force-pushed the feat/optimization-doc-image branch from 3d20b70 to bb5bfed Compare July 6, 2024 06:35
@Jocs Jocs force-pushed the feat/optimization-doc-image branch 4 times, most recently from 65c45a4 to bb7dbb4 Compare July 9, 2024 08:43
@Jocs Jocs force-pushed the feat/optimization-doc-image branch from 1fb5193 to 7520a7b Compare July 9, 2024 09:12
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jul 11, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jul 11, 2024
@Jocs Jocs merged commit 3f98681 into dev Jul 11, 2024
9 checks passed
@Jocs Jocs deleted the feat/optimization-doc-image branch July 11, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants