Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: everything feels very lag when there is a long range dashrect(cliparea) #2472

Merged
merged 6 commits into from
Jun 19, 2024
Merged

feat: everything feels very lag when there is a long range dashrect(cliparea) #2472

merged 6 commits into from
Jun 19, 2024

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Jun 11, 2024 •
edited
Loading

close #1078

https://github.com/dream-num/univer-pro/issues/1078

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@lumixraku lumixraku changed the title Chore/cell click lag feat: cell click lag when long range dashrect Jun 11, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 1.51515% with 65 lines in your changes missing coverage. Please review.

Project coverage is 27.15%. Comparing base (4885f4f) to head (9e7c1cb).

Files Patch % Lines
packages/engine-render/src/shape/rect.ts 0.00% 32 Missing ⚠️
packages/engine-render/src/viewport.ts 0.00% 10 Missing ⚠️
packages/core/src/shared/rectangle.ts 0.00% 9 Missing ⚠️
packages/engine-render/src/group.ts 0.00% 4 Missing ⚠️
...ne-render/src/components/sheets/extensions/font.ts 0.00% 3 Missing ⚠️
packages/engine-render/src/shape/shape.ts 0.00% 2 Missing ⚠️
...heets-ui/src/services/selection/selection-shape.ts 33.33% 2 Missing ⚠️
packages/engine-render/src/base-object.ts 0.00% 1 Missing ⚠️
...engine-render/src/components/sheets/spreadsheet.ts 0.00% 1 Missing ⚠️
...lers/render-controllers/sheet-render.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #2472      +/-   ##
==========================================
- Coverage   27.15%   27.15%   -0.01%     
==========================================
  Files        1653     1653              
  Lines       83562    83598      +36     
  Branches    17384    17391       +7     
==========================================
+ Hits        22691    22700       +9     
- Misses      60871    60898      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@lumixraku lumixraku added the qa:untested This PR is ready to be tested label Jun 11, 2024
@lumixraku lumixraku changed the title feat: cell click lag when long range dashrect feat: everything feels very lag when long range dashrect Jun 11, 2024
@lumixraku lumixraku changed the title feat: everything feels very lag when long range dashrect feat: everything feels very lag when there is a long range dashrect Jun 11, 2024
@lumixraku lumixraku changed the title feat: everything feels very lag when there is a long range dashrect feat: everything feels very lag when there is a long range dashrect(cliparea) Jun 11, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jun 14, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jun 14, 2024
@wzhudev wzhudev merged commit 45f15fe into dev Jun 19, 2024
9 checks passed
@wzhudev wzhudev deleted the chore/cell-click-lag branch June 19, 2024 02:44
wzhudev added a commit that referenced this pull request Jul 8, 2024
@wzhudev
refactor: rename basic files
318ec96 
refactor(docs-ui): refactor doc rendering to render unit

fix: fix error emitted

refactor: refactor zoom controller

refactor: refactor back scroll render controller

refactor: move doc skeleton manager into render unit

refactor: refactor doc drawing

refactor: refactor editor related modules

fix: fix type error

WIP

refactor: refactor doc view model

test: fix docs test

fix: fix import error

test: fix facade test

fix: fix e2e test

chore: change editor unit name

chore: update code style

fix: fix formula editor cannot be activated

fix: fix render blinking

fix: fix sheet editor cannot be updated

fix: button style (#2541)

* fix(sheet): style issue

* chore: range modal delete button style

chore: update dependencies & limit maximum concurrency for turbo execution (#2543)

fix(sheets-ui): fix unhide render controller RENDER_COMMANDS (#2516)

fix(sheets): hide rows cols should skip over already hidden ranges (#2517)

fix: use @univerjs/ui useObservable (#2456)

fix(design): fix popup position (#2510)

fix(sheets-drawing-ui): error delete cache when float-dom hide (#2540)

feat: everything feels very lag when there is a long range dashrect(cliparea) (#2472)

* fix: moving getCell lower

* fix: try to draw dashrect in visible area

* chore: rm useless

* fix: do not use startXY as IRect props to get viewport pos

fix(sheets): fix some bugs (#2545)

* fix(sheets): fix some bugs

* chore: change test

* fix: bugfix

chore(ci): fix sync:cnpm (#2525)

feat: init uni mode ui layout

fix: fix scroll problems

fix: fix sheet bar tabs

feat: add focus style

fix: all workbooks need to initialized

fix: fix zoom slider

chore: clean code

fix: fix editor position
wzhudev added a commit that referenced this pull request Jul 8, 2024
@wzhudev
refactor: rename basic files
682951d 
refactor(docs-ui): refactor doc rendering to render unit

fix: fix error emitted

refactor: refactor zoom controller

refactor: refactor back scroll render controller

refactor: move doc skeleton manager into render unit

refactor: refactor doc drawing

refactor: refactor editor related modules

fix: fix type error

WIP

refactor: refactor doc view model

test: fix docs test

fix: fix import error

test: fix facade test

fix: fix e2e test

chore: change editor unit name

chore: update code style

fix: fix formula editor cannot be activated

fix: fix render blinking

fix: fix sheet editor cannot be updated

fix: button style (#2541)

* fix(sheet): style issue

* chore: range modal delete button style

chore: update dependencies & limit maximum concurrency for turbo execution (#2543)

fix(sheets-ui): fix unhide render controller RENDER_COMMANDS (#2516)

fix(sheets): hide rows cols should skip over already hidden ranges (#2517)

fix: use @univerjs/ui useObservable (#2456)

fix(design): fix popup position (#2510)

fix(sheets-drawing-ui): error delete cache when float-dom hide (#2540)

feat: everything feels very lag when there is a long range dashrect(cliparea) (#2472)

* fix: moving getCell lower

* fix: try to draw dashrect in visible area

* chore: rm useless

* fix: do not use startXY as IRect props to get viewport pos

fix(sheets): fix some bugs (#2545)

* fix(sheets): fix some bugs

* chore: change test

* fix: bugfix

chore(ci): fix sync:cnpm (#2525)

feat: init uni mode ui layout

fix: fix scroll problems

fix: fix sheet bar tabs

feat: add focus style

fix: all workbooks need to initialized

fix: fix zoom slider

chore: clean code

fix: fix editor position
wzhudev added a commit that referenced this pull request Jul 8, 2024
@wzhudev
refactor: rename basic files
923bf36 
refactor(docs-ui): refactor doc rendering to render unit

fix: fix error emitted

refactor: refactor zoom controller

refactor: refactor back scroll render controller

refactor: move doc skeleton manager into render unit

refactor: refactor doc drawing

refactor: refactor editor related modules

fix: fix type error

WIP

refactor: refactor doc view model

test: fix docs test

fix: fix import error

test: fix facade test

fix: fix e2e test

chore: change editor unit name

chore: update code style

fix: fix formula editor cannot be activated

fix: fix render blinking

fix: fix sheet editor cannot be updated

fix: button style (#2541)

* fix(sheet): style issue

* chore: range modal delete button style

chore: update dependencies & limit maximum concurrency for turbo execution (#2543)

fix(sheets-ui): fix unhide render controller RENDER_COMMANDS (#2516)

fix(sheets): hide rows cols should skip over already hidden ranges (#2517)

fix: use @univerjs/ui useObservable (#2456)

fix(design): fix popup position (#2510)

fix(sheets-drawing-ui): error delete cache when float-dom hide (#2540)

feat: everything feels very lag when there is a long range dashrect(cliparea) (#2472)

* fix: moving getCell lower

* fix: try to draw dashrect in visible area

* chore: rm useless

* fix: do not use startXY as IRect props to get viewport pos

fix(sheets): fix some bugs (#2545)

* fix(sheets): fix some bugs

* chore: change test

* fix: bugfix

chore(ci): fix sync:cnpm (#2525)

feat: init uni mode ui layout

fix: fix scroll problems

fix: fix sheet bar tabs

feat: add focus style

fix: all workbooks need to initialized

fix: fix zoom slider

chore: clean code

fix: fix editor position
wzhudev added a commit that referenced this pull request Jul 8, 2024
@wzhudev
refactor: rename basic files
c351b41 
refactor(docs-ui): refactor doc rendering to render unit

fix: fix error emitted

refactor: refactor zoom controller

refactor: refactor back scroll render controller

refactor: move doc skeleton manager into render unit

refactor: refactor doc drawing

refactor: refactor editor related modules

fix: fix type error

WIP

refactor: refactor doc view model

test: fix docs test

fix: fix import error

test: fix facade test

fix: fix e2e test

chore: change editor unit name

chore: update code style

fix: fix formula editor cannot be activated

fix: fix render blinking

fix: fix sheet editor cannot be updated

fix: button style (#2541)

* fix(sheet): style issue

* chore: range modal delete button style

chore: update dependencies & limit maximum concurrency for turbo execution (#2543)

fix(sheets-ui): fix unhide render controller RENDER_COMMANDS (#2516)

fix(sheets): hide rows cols should skip over already hidden ranges (#2517)

fix: use @univerjs/ui useObservable (#2456)

fix(design): fix popup position (#2510)

fix(sheets-drawing-ui): error delete cache when float-dom hide (#2540)

feat: everything feels very lag when there is a long range dashrect(cliparea) (#2472)

* fix: moving getCell lower

* fix: try to draw dashrect in visible area

* chore: rm useless

* fix: do not use startXY as IRect props to get viewport pos

fix(sheets): fix some bugs (#2545)

* fix(sheets): fix some bugs

* chore: change test

* fix: bugfix

chore(ci): fix sync:cnpm (#2525)

feat: init uni mode ui layout

fix: fix scroll problems

fix: fix sheet bar tabs

feat: add focus style

fix: all workbooks need to initialized

fix: fix zoom slider

chore: clean code

fix: fix editor position
wzhudev added a commit that referenced this pull request Jul 8, 2024
@wzhudev
refactor: rename basic files
a97d859 
refactor(docs-ui): refactor doc rendering to render unit

fix: fix error emitted

refactor: refactor zoom controller

refactor: refactor back scroll render controller

refactor: move doc skeleton manager into render unit

refactor: refactor doc drawing

refactor: refactor editor related modules

fix: fix type error

WIP

refactor: refactor doc view model

test: fix docs test

fix: fix import error

test: fix facade test

fix: fix e2e test

chore: change editor unit name

chore: update code style

fix: fix formula editor cannot be activated

fix: fix render blinking

fix: fix sheet editor cannot be updated

fix: button style (#2541)

* fix(sheet): style issue

* chore: range modal delete button style

chore: update dependencies & limit maximum concurrency for turbo execution (#2543)

fix(sheets-ui): fix unhide render controller RENDER_COMMANDS (#2516)

fix(sheets): hide rows cols should skip over already hidden ranges (#2517)

fix: use @univerjs/ui useObservable (#2456)

fix(design): fix popup position (#2510)

fix(sheets-drawing-ui): error delete cache when float-dom hide (#2540)

feat: everything feels very lag when there is a long range dashrect(cliparea) (#2472)

* fix: moving getCell lower

* fix: try to draw dashrect in visible area

* chore: rm useless

* fix: do not use startXY as IRect props to get viewport pos

fix(sheets): fix some bugs (#2545)

* fix(sheets): fix some bugs

* chore: change test

* fix: bugfix

chore(ci): fix sync:cnpm (#2525)

feat: init uni mode ui layout

fix: fix scroll problems

fix: fix sheet bar tabs

feat: add focus style

fix: all workbooks need to initialized

fix: fix zoom slider

chore: clean code

fix: fix editor position
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DR-Univer DR-Univer DR-Univer approved these changes

@jikkai jikkai Awaiting requested review from jikkai jikkai is a code owner

@Jocs Jocs Awaiting requested review from Jocs

@wzhudev wzhudev Awaiting requested review from wzhudev wzhudev is a code owner

Assignees
No one assigned
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] components for features on Jan
4 participants
@lumixraku @DR-Univer @wzhudev @zhaolixin7