Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(find): when dispose, should close panel #2495

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fix(find): when dispose, should close panel #2495

merged 1 commit into from
Jun 12, 2024

Conversation

VicKun4937
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

wzhudev
wzhudev approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VicKun4937 VicKun4937 merged commit 4a72bcc into dev Jun 12, 2024
9 checks passed
@VicKun4937 VicKun4937 deleted the fix-find-replace-not-dispose-ui branch June 12, 2024 13:01
@github-actions GitHub Actions
Copy link

View Deployment

#9483225554

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

@siam-ese siam-ese Awaiting requested review from siam-ese siam-ese is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VicKun4937 @wzhudev