Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix disposing univer causing error #2515

Merged
merged 5 commits into from
Jun 13, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jun 13, 2024

close #2351

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 27.16%. Comparing base (adc1e1f) to head (3743632).
Report is 1 commits behind head on dev.

Files Patch % Lines
...s/ui/src/views/components/doc-bars/ToolbarItem.tsx 0.00% 3 Missing ⚠️
...core/src/services/permission/permission.service.ts 0.00% 2 Missing ⚠️
...ages/ui/src/views/components/popup/CanvasPopup.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2515   +/-   ##
=======================================
  Coverage   27.16%   27.16%           
=======================================
  Files        1653     1653           
  Lines       83358    83357    -1     
  Branches    17263    17263           
=======================================
+ Hits        22642    22643    +1     
+ Misses      60716    60714    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 13, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev wzhudev merged commit ca76011 into dev Jun 13, 2024
8 of 9 checks passed
@wzhudev wzhudev deleted the wzhudev/fix/fix-disposion-error branch June 13, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] UMD method introduces universal. Error: [redi]: Injector cannot be accessed after it was disposed.
1 participant