Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs-drawing): fix crash when editing text after inserting images and opening the sidebar #2548

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Jun 19, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@jikkai jikkai requested a review from Jocs June 19, 2024 03:18
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.18%. Comparing base (54edf21) to head (d7d0aff).

Files Patch % Lines
...g-ui/src/views/doc-image-panel/DocDrawingPanel.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2548   +/-   ##
=======================================
  Coverage   27.18%   27.18%           
=======================================
  Files        1653     1653           
  Lines       83623    83622    -1     
  Branches    17400    17401    +1     
=======================================
  Hits        22729    22729           
+ Misses      60894    60893    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 19, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Jocs Jocs merged commit f59ab40 into dev Jun 19, 2024
9 checks passed
@Jocs Jocs deleted the fix/docs-images branch June 19, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants