Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): selection order #2557

Merged
merged 1 commit into from
Jun 21, 2024
Merged

fix(sheet): selection order #2557

merged 1 commit into from
Jun 21, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Jun 19, 2024

close #1250

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@DR-Univer DR-Univer requested review from jikkai and wzhudev as code owners June 19, 2024 09:17
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.10%. Comparing base (f3641c3) to head (a8f8bbf).
Report is 2 commits behind head on dev.

Files Patch % Lines
.../render-controllers/selection.render-controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2557      +/-   ##
==========================================
- Coverage   27.17%   27.10%   -0.07%     
==========================================
  Files        1653     1654       +1     
  Lines       83689    83897     +208     
  Branches    17422    17459      +37     
==========================================
+ Hits        22741    22744       +3     
- Misses      60948    61153     +205     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 19, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit eb47033 into dev Jun 21, 2024
12 of 13 checks passed
@wzhudev wzhudev deleted the fix-selection-order branch June 21, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants