Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(permission): can not edit when have not permission in cn language #2574

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Jun 20, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.06%. Comparing base (70372f8) to head (5bbadf6).
Report is 2 commits behind head on dev.

Files Patch % Lines
...on/sheet-permission-interceptor-base.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2574      +/-   ##
==========================================
+ Coverage   27.02%   27.06%   +0.03%     
==========================================
  Files        1677     1677              
  Lines       84748    84764      +16     
  Branches    17622    17626       +4     
==========================================
+ Hits        22905    22938      +33     
+ Misses      61843    61826      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ybzky ybzky changed the title fix: fix cn can edit when have not permission fix(permission): can not edit when have not permission in cn language Jun 20, 2024
Copy link

github-actions bot commented Jun 20, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 7f996f1 into dev Jun 21, 2024
10 checks passed
@wzhudev wzhudev deleted the fix-cn-permission branch June 21, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants