Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): ui dependency #2577

Merged
merged 1 commit into from
Jun 21, 2024
Merged

fix(sheet): ui dependency #2577

merged 1 commit into from
Jun 21, 2024

Conversation

yuhongz
Copy link
Contributor

@yuhongz yuhongz commented Jun 20, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 27.04%. Comparing base (d1e38dd) to head (84db9fa).

Files Patch % Lines
...rt-ui/src/controllers/sheets-sort-ui.controller.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2577      +/-   ##
==========================================
- Coverage   27.06%   27.04%   -0.02%     
==========================================
  Files        1677     1677              
  Lines       84763    84761       -2     
  Branches    17625    17625              
==========================================
- Hits        22938    22925      -13     
- Misses      61825    61836      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 20, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 55f6f72 into dev Jun 21, 2024
13 checks passed
@wzhudev wzhudev deleted the yuhongz/fix-sort branch June 21, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants