Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: doc support header and footer #2589

Merged
merged 39 commits into from
Jul 5, 2024
Merged

feat: doc support header and footer #2589

merged 39 commits into from
Jul 5, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Jun 22, 2024

close https://github.com/dream-num/univer-pro/issues/1307

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 4.40487% with 1020 lines in your changes missing coverage. Please review.

Project coverage is 26.70%. Comparing base (a2fd4ed) to head (56cb803).
Report is 1 commits behind head on dev.

Files Patch % Lines
...ui/src/controllers/doc-header-footer.controller.ts 0.00% 165 Missing ⚠️
...-render/src/components/docs/layout/doc-skeleton.ts 0.00% 129 Missing ⚠️
...src/commands/commands/doc-header-footer.command.ts 0.00% 101 Missing ⚠️
...ages/engine-render/src/components/docs/document.ts 0.00% 92 Missing ⚠️
...ews/header-footer/panel/DocHeaderFooterOptions.tsx 0.00% 75 Missing ⚠️
...ges/docs-ui/src/views/header-footer/text-bubble.ts 0.00% 59 Missing ⚠️
...kages/docs/src/commands/commands/delete.command.ts 0.00% 52 Missing ⚠️
...c/components/docs/text-selection/convert-cursor.ts 0.00% 38 Missing ⚠️
...cs/text-selection/text-selection-render-manager.ts 0.00% 35 Missing ⚠️
...er-controllers/text-selection.render-controller.ts 0.00% 22 Missing ⚠️
... and 27 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2589      +/-   ##
==========================================
- Coverage   26.92%   26.70%   -0.23%     
==========================================
  Files        1636     1643       +7     
  Lines       87997    88787     +790     
  Branches    18554    18744     +190     
==========================================
+ Hits        23695    23707      +12     
- Misses      64302    65080     +778     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 24, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Jocs Jocs marked this pull request as ready for review June 28, 2024 13:45
@Jocs Jocs added the qa:untested This PR is ready to be tested label Jun 28, 2024
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jul 3, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jul 3, 2024
@DR-Univer
Copy link
Collaborator

image
sheet editor 左上角和右上角有残留得header图标。

@univer-bot
Copy link

univer-bot bot commented Jul 5, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

image
There are residual header icons in the upper left and upper right corners of the sheet editor.

@DR-Univer
Copy link
Collaborator

image
普通editor也有

@univer-bot
Copy link

univer-bot bot commented Jul 5, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

image
Ordinary editors also have it

@Jocs Jocs merged commit 9b6cdf6 into dev Jul 5, 2024
9 checks passed
@Jocs Jocs deleted the feat/doc-header-footer branch July 5, 2024 09:48
@jikkai jikkai restored the feat/doc-header-footer branch July 9, 2024 08:57
@jikkai jikkai deleted the feat/doc-header-footer branch July 15, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants