Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(range-selector): placeholder flush #2607

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

Gggpound
Copy link
Contributor

close 466

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 27.11%. Comparing base (2d5de98) to head (cfa9c8d).
Report is 2 commits behind head on dev.

Files Patch % Lines
...atting-ui/src/components/panel/rule-edit/index.tsx 0.00% 15 Missing ⚠️
packages/ui/src/components/editor/TextEditor.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2607      +/-   ##
==========================================
- Coverage   27.12%   27.11%   -0.01%     
==========================================
  Files        1675     1675              
  Lines       84653    84702      +49     
  Branches    17642    17653      +11     
==========================================
+ Hits        22961    22968       +7     
- Misses      61692    61734      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 24, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jun 25, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jun 25, 2024
@Gggpound Gggpound merged commit 2dc7ce0 into dev Jun 25, 2024
9 checks passed
@Gggpound Gggpound deleted the fix-range-selector-0624 branch June 25, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants