Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix some paste bugs #2612

Merged
merged 10 commits into from
Jun 26, 2024
Merged

fix: fix some paste bugs #2612

merged 10 commits into from
Jun 26, 2024

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Jun 25, 2024

close #1998 https://github.com/dream-num/univer-pro/issues/1323 https://github.com/dream-num/univer-pro/issues/1322 https://github.com/dream-num/univer-pro/issues/1342

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 67.64706% with 11 lines in your changes missing coverage. Please review.

Project coverage is 26.94%. Comparing base (b523f62) to head (910ecfb).
Report is 14 commits behind head on dev.

Files Patch % Lines
...la/src/controllers/formula-clipboard.controller.ts 20.00% 4 Missing ⚠️
...kages/sheets-ui/src/controllers/clipboard/utils.ts 76.92% 3 Missing ⚠️
...ui/src/services/clipboard/html-to-udm/converter.ts 75.00% 1 Missing ⚠️
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 1 Missing ⚠️
...ets-ui/src/services/clipboard/clipboard.service.ts 50.00% 1 Missing ⚠️
packages/ui/src/utils/cell.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2612      +/-   ##
==========================================
- Coverage   27.10%   26.94%   -0.16%     
==========================================
  Files        1676     1693      +17     
  Lines       84746    85176     +430     
  Branches    17660    17748      +88     
==========================================
- Hits        22968    22954      -14     
- Misses      61778    62222     +444     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 25, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@zhaolixin7
Copy link

zhaolixin7 commented Jun 26, 2024

@ybzky1、 复制外部内容粘贴到univer后格式未被覆盖
2、粘贴后编辑位置有点偏左
2024_6_26 16_29_09 video.webm

@univer-bot
Copy link

univer-bot bot commented Jun 26, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@ybzky1, the format is not overwritten after copying external content and pasting it into univer
2. After pasting, the editing position is a bit to the left.
2024_6_26 16_29_09 video.webm

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jun 26, 2024
@ybzky ybzky requested a review from lumixraku as a code owner June 26, 2024 08:42
@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:rejected labels Jun 26, 2024
@ybzky ybzky merged commit cfd3227 into dev Jun 26, 2024
9 checks passed
@ybzky ybzky deleted the ybzky/fix-paste-bugs branch June 26, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Copy the number format in excel and paste it into univer without retaining the format
3 participants