Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(thread-comment): support server intercept for comment & docs-comment #2619

Merged
merged 129 commits into from
Jul 4, 2024
Merged

feat(thread-comment): support server intercept for comment & docs-comment #2619

merged 129 commits into from
Jul 4, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jun 26, 2024 •
edited
Loading

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jul 2, 2024
@weird94 weird94 changed the title feat(thread-comment): support server intercept for comment feat(thread-comment): support server intercept for comment & docs-comment Jul 2, 2024
@weird94 weird94 merged commit 02dff82 into dev Jul 4, 2024
6 of 9 checks passed
@weird94 weird94 deleted the feat/comment-intecept branch July 4, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jikkai jikkai jikkai approved these changes

@wzhudev wzhudev Awaiting requested review from wzhudev wzhudev is a code owner

@Jocs Jocs Awaiting requested review from Jocs Jocs is a code owner

@DR-Univer DR-Univer Awaiting requested review from DR-Univer

@Dushusir Dushusir Awaiting requested review from Dushusir Dushusir is a code owner

@hexf00 hexf00 Awaiting requested review from hexf00 hexf00 is a code owner

@lumixraku lumixraku Awaiting requested review from lumixraku lumixraku is a code owner

@Gggpound Gggpound Awaiting requested review from Gggpound Gggpound is a code owner

Assignees
No one assigned
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weird94 @jikkai @zhaolixin7