Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): freeze invalid #2658

Merged
merged 2 commits into from
Jul 2, 2024
Merged

fix(sheet): freeze invalid #2658

merged 2 commits into from
Jul 2, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Jul 2, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Jul 2, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@DR-Univer DR-Univer requested a review from lumixraku as a code owner July 2, 2024 07:19
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 27.39%. Comparing base (909f2ee) to head (75751b2).
Report is 4 commits behind head on dev.

Files Patch % Lines
...ers/render-controllers/freeze.render-controller.ts 0.00% 19 Missing ⚠️
...gine-render/src/components/sheets/column-header.ts 0.00% 2 Missing ⚠️
.../engine-render/src/components/sheets/row-header.ts 0.00% 2 Missing ⚠️
...engine-render/src/components/sheets/spreadsheet.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2658      +/-   ##
==========================================
- Coverage   27.40%   27.39%   -0.02%     
==========================================
  Files        1707     1707              
  Lines       85677    85852     +175     
  Branches    17906    17941      +35     
==========================================
+ Hits        23481    23515      +34     
- Misses      62196    62337     +141     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer DR-Univer merged commit 03982b7 into dev Jul 2, 2024
9 checks passed
@DR-Univer DR-Univer deleted the fix-freeze-grab-invalid branch July 2, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant