Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheet): sheet name check #2660

Merged
merged 1 commit into from
Jul 2, 2024
Merged

feat(sheet): sheet name check #2660

merged 1 commit into from
Jul 2, 2024

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Jul 2, 2024

close #1208

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Dushusir Dushusir added the qa:untested This PR is ready to be tested label Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 44.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 27.39%. Comparing base (909f2ee) to head (e2b23aa).
Report is 5 commits behind head on dev.

Files Patch % Lines
...rc/views/sheet-bar/sheet-bar-tabs/SheetBarTabs.tsx 0.00% 13 Missing ⚠️
...ws/sheet-bar/sheet-bar-tabs/utils/slide-tab-bar.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2660      +/-   ##
==========================================
- Coverage   27.40%   27.39%   -0.02%     
==========================================
  Files        1707     1708       +1     
  Lines       85677    85873     +196     
  Branches    17906    17946      +40     
==========================================
+ Hits        23481    23524      +43     
- Misses      62196    62349     +153     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 2, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Jul 2, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit fd8f8ac into dev Jul 2, 2024
9 checks passed
@wzhudev wzhudev deleted the dushusir/sheet-related branch July 2, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]工作表重命名有特护符号时预期有限制提示
3 participants