Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-ui): fix focusout issue with rename input box in lower version of React #2662

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Jul 2, 2024

close #2648

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@jikkai jikkai requested a review from wzhudev as a code owner July 2, 2024 09:30
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 27.39%. Comparing base (fd8f8ac) to head (58a8697).

Files Patch % Lines
...ws/sheet-bar/sheet-bar-tabs/utils/slide-tab-bar.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2662   +/-   ##
=======================================
  Coverage   27.39%   27.39%           
=======================================
  Files        1708     1708           
  Lines       85873    85873           
  Branches    17946    17946           
=======================================
  Hits        23526    23526           
  Misses      62347    62347           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 2, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@jikkai jikkai merged commit 6f74450 into dev Jul 2, 2024
8 of 9 checks passed
@jikkai jikkai deleted the fix/foucus-sheets-tab branch July 2, 2024 09:47
@jikkai jikkai removed the qa:untested This PR is ready to be tested label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] react 16.8 compatibility issues
1 participant