Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): drawing switch tab position error #2686

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Jul 4, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@DR-Univer DR-Univer requested a review from siam-ese July 4, 2024 09:12
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 26.82%. Comparing base (0c6f5ec) to head (62334dc).

Files Patch % Lines
...ers/sheet-drawing-transform-affected.controller.ts 0.00% 21 Missing ⚠️
...wing-ui/src/controllers/image-update.controller.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2686      +/-   ##
==========================================
- Coverage   26.83%   26.82%   -0.01%     
==========================================
  Files        1627     1627              
  Lines       87908    87912       +4     
  Branches    18533    18533              
==========================================
  Hits        23586    23586              
- Misses      64322    64326       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer DR-Univer merged commit e1549e0 into dev Jul 4, 2024
13 checks passed
@DR-Univer DR-Univer deleted the fix-sheet-drawing-switch-tab branch July 4, 2024 09:18
Copy link

github-actions bot commented Jul 4, 2024

View Deployment

#9791746390

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

weird94 added a commit that referenced this pull request Jul 5, 2024
* feat: update

* feat: temp

* feat: temp

* feat: temp

* feat: temp

* feat: temp

* feat: update

* feat: delete

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: comment

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: bugfix

* feat: update

* feat: update

* feat: update

* feat: lint

* feat: show filter

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update-ref

* feat: u

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: fix doc copy

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* fix: fix lockfile

* feat: update

* feat: update

* feat: update

* feat: update

* feat: temp

* feat: update

* feat: update

* feat: update

* fix: #1267

* fix: checkbox formula #1363

* fix: checkbox

* fix: data-validation checkbox

* feat: update

* feat: update

* feat: update remove-sheet

* feat: lint

* feat: update

* feat: update

* fix: #1391

* feat: update

* feat: update

* fix: univer-pro #1407

* feat: update

* feat: update

* feat: lint

* feat: update

* feat: update

* feat: update

* feat: update

* feat: reset data

* feat: update doc-hyper-link-plugin

* feat: export commands

* feat: temp

* feat: remove console

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* text: fix test case (#2683)

* fix: add correct RU translation in Sort and Hyperlink plugins (#2685)

* feat: lock

* fix(sheet): drawing switch tab position error (#2686)

* feat: fix hyperlink copy

* feat: update

* feat: update

* feat(formula): add asin function (#2620)

* feat(formula): add asin function

* feat(formula): add asinh function

* feat(formula): add tan,tanh functions

* test(formula): acot test

* fix(formula): function atan2 calculation

* fix(sheet): strip every number cell

* fix(sheet): remove unused module

* fix(sheet): skip numfmt pattern in number cell interceptor

* feat: update

* feat: update

* ci: fix ci (#2687)

* feat: fix update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* fix: update

* fix: update

* feat: update

* feat: update

* feat: update

* fix: eslint

* feat: update

* feat: rename

* feat: update

* feat: update

* feat: update

* feat: update

---------

Co-authored-by: 白熱 <sonne@asaki.me>
Co-authored-by: scorp1k <65504800+scorp1k@users.noreply.github.com>
Co-authored-by: Univer <68851825+DR-Univer@users.noreply.github.com>
Co-authored-by: Dushusir <1414556676@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants