Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs-ui): disable link & comment on header footer #2700

Merged
merged 3 commits into from
Jul 6, 2024
Merged

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jul 6, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jul 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 26.50%. Comparing base (ef0ae96) to head (031e495).

Files Patch % Lines
...ges/docs-thread-comment-ui/src/controllers/menu.ts 0.00% 14 Missing ⚠️
...controllers/doc-hyper-link-selection.controller.ts 0.00% 9 Missing ⚠️
...link-ui/src/commands/operations/popup.operation.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2700   +/-   ##
=======================================
  Coverage   26.50%   26.50%           
=======================================
  Files        1668     1668           
  Lines       89449    89476   +27     
  Branches    18849    18852    +3     
=======================================
+ Hits        23709    23719   +10     
- Misses      65740    65757   +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 6, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:verified This PR has already by verified by a QA and is considered good enough to be merge labels Jul 6, 2024
@jikkai jikkai merged commit f93a229 into dev Jul 6, 2024
9 checks passed
@jikkai jikkai deleted the fix/docs-link branch July 6, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants