Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tons of memory leak #2754

Merged
merged 3 commits into from
Jul 12, 2024
Merged

fix: tons of memory leak #2754

merged 3 commits into from
Jul 12, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jul 12, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Jul 12, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link
Member

@jikkai jikkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 14 lines in your changes missing coverage. Please review.

Project coverage is 25.94%. Comparing base (9606194) to head (334caed).

Files Patch % Lines
...ula/src/services/register-other-formula.service.ts 0.00% 4 Missing ⚠️
...es/ui/src/controllers/ui/ui-desktop.controller.tsx 0.00% 3 Missing ⚠️
...es/core/src/common/request-immediate-macro-task.ts 0.00% 2 Missing ⚠️
packages/engine-render/src/engine.ts 0.00% 2 Missing ⚠️
...cs/text-selection/text-selection-render-manager.ts 0.00% 1 Missing ⚠️
packages/engine-render/src/layer.ts 0.00% 1 Missing ⚠️
...s-data-validation/src/controllers/dv.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2754   +/-   ##
=======================================
  Coverage   25.94%   25.94%           
=======================================
  Files        1691     1691           
  Lines       90649    90665   +16     
  Branches    19130    19129    -1     
=======================================
+ Hits        23515    23520    +5     
- Misses      67134    67145   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev merged commit 3f3dcff into dev Jul 12, 2024
9 checks passed
@wzhudev wzhudev deleted the fix/memory-leak branch July 12, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants