Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-validation): code optimize for data-validation #2815

Merged
merged 5 commits into from
Jul 20, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jul 18, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.

Project coverage is 26.71%. Comparing base (ea92192) to head (6efb604).

Files Patch % Lines
...validation/src/controllers/dv-render.controller.ts 0.00% 20 Missing ⚠️
...src/commands/mutations/data-validation.mutation.ts 0.00% 7 Missing ⚠️
...ata-validation/src/models/data-validation-model.ts 0.00% 7 Missing ⚠️
...a-validation/src/models/data-validation-manager.ts 0.00% 3 Missing ⚠️
...n/src/commands/commands/data-validation.command.ts 0.00% 2 Missing ⚠️
...lidation/src/controllers/dv-resource.controller.ts 0.00% 1 Missing ⚠️
...n/src/commands/commands/data-validation.command.ts 0.00% 1 Missing ⚠️
...idation/src/controllers/dv-auto-fill.controller.ts 0.00% 1 Missing ⚠️
...s-data-validation/src/controllers/dv.controller.ts 0.00% 1 Missing ⚠️
...dation/src/models/sheet-data-validation-manager.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2815   +/-   ##
=======================================
  Coverage   26.71%   26.71%           
=======================================
  Files        1772     1772           
  Lines       93515    93507    -8     
  Branches    19923    19926    +3     
=======================================
  Hits        24982    24982           
+ Misses      68533    68525    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 19, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@weird94 weird94 merged commit ab242a3 into dev Jul 20, 2024
9 checks passed
@weird94 weird94 deleted the feat/data-validation-optimize branch July 20, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants