Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): support doc-hover-service #2824

Merged
merged 6 commits into from
Jul 20, 2024
Merged

feat(docs): support doc-hover-service #2824

merged 6 commits into from
Jul 20, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jul 19, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Jul 19, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 85 lines in your changes missing coverage. Please review.

Project coverage is 26.70%. Comparing base (ab242a3) to head (2a65730).

Files Patch % Lines
.../docs-ui/src/services/doc-hover-manager.service.ts 0.00% 60 Missing ⚠️
.../render-controllers/doc-hover.render-controller.ts 0.00% 18 Missing ⚠️
packages/core/src/observer/observable.ts 0.00% 5 Missing ⚠️
packages/docs/src/basics/selection.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2824      +/-   ##
==========================================
- Coverage   26.71%   26.70%   -0.02%     
==========================================
  Files        1772     1773       +1     
  Lines       93507    93552      +45     
  Branches    19926    19931       +5     
==========================================
  Hits        24982    24982              
- Misses      68525    68570      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 28dbb78 into dev Jul 20, 2024
9 checks passed
@wzhudev wzhudev deleted the feat/doc-hover branch July 20, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants