Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get SheetScrollManagerService from renderManagerSrv #2833

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

lumixraku
Copy link
Contributor

close https://github.com/dream-num/univer-pro/issues/1712

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jul 22, 2024
@lumixraku lumixraku mentioned this pull request Jul 22, 2024
2 tasks
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.68%. Comparing base (a0c858e) to head (2ae1bc9).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2833   +/-   ##
=======================================
  Coverage   26.68%   26.68%           
=======================================
  Files        1773     1773           
  Lines       93545    93546    +1     
  Branches    19905    19905           
=======================================
+ Hits        24965    24966    +1     
  Misses      68580    68580           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 22, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@lumixraku lumixraku removed the qa:untested This PR is ready to be tested label Jul 22, 2024
@lumixraku lumixraku merged commit ce4e7c4 into dev Jul 22, 2024
9 checks passed
@lumixraku lumixraku deleted the fix/scrollManagerService branch July 22, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants