Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-drawing-ui): load float-dom from snapshot & support presist custom data with float dom drawing object #2841

Merged
merged 5 commits into from
Jul 23, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jul 23, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Jul 23, 2024

View Deployment

#10055551325

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

@weird94 weird94 changed the title feat(sheets-drawing-ui): support presist custom data with float dom drawing object fix(sheets-drawing-ui): load float-dom from snapshot & support presist custom data with float dom drawing object Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 26.71%. Comparing base (28dbb78) to head (4ca75a8).
Report is 11 commits behind head on dev.

Files Patch % Lines
...i/src/services/canvas-float-dom-manager.service.ts 0.00% 4 Missing ⚠️
packages/ui/src/views/components/dom/FloatDom.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##              dev    #2841    +/-   ##
========================================
  Coverage   26.70%   26.71%            
========================================
  Files        1773     1774     +1     
  Lines       93552    93684   +132     
  Branches    19931    19934     +3     
========================================
+ Hits        24982    25023    +41     
- Misses      68570    68661    +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/debugger/src/components/Image.tsx Outdated Show resolved Hide resolved
packages/debugger/src/debugger-plugin.ts Outdated Show resolved Hide resolved
packages/core/src/common/json.ts Outdated Show resolved Hide resolved
@weird94 weird94 merged commit ca38723 into dev Jul 23, 2024
9 checks passed
@weird94 weird94 deleted the feat/float-dom-data branch July 23, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants