Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sheet): type import #2848

Merged
merged 3 commits into from
Jul 24, 2024
Merged

fix(sheet): type import #2848

merged 3 commits into from
Jul 24, 2024

Conversation

VicKun4937
Copy link
Contributor

  • add type import
  • the has function should use undefined instead of null

@VicKun4937 VicKun4937 requested a review from DR-Univer as a code owner July 24, 2024 03:04
@VicKun4937 VicKun4937 changed the title Fix type import fix(sheet): type import Jul 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

View Deployment

#10070274011

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

wzhudev
wzhudev approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/engine-formula/src/services/feature-calculation-manager.service.ts Outdated
@@ -84,7 +84,7 @@ export class FeatureCalculationManagerService extends Disposable implements IFea
}

has(unitId: string, subUnitId: string, featureId: string): boolean {
return this._referenceExecutorMap.get(unitId)?.get(subUnitId)?.has(featureId) !== null;
return this._referenceExecutorMap.get(unitId)?.get(subUnitId)?.has(featureId) !== undefined;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接在前面 !! 不就好了，直接无脑捕获所有空值

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我自己写的话，一般直接boonlean(xxxx)

@VicKun4937 VicKun4937 merged commit ae0b012 into dev Jul 24, 2024
9 checks passed
@VicKun4937 VicKun4937 deleted the fix-type-import branch July 24, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

@DR-Univer DR-Univer Awaiting requested review from DR-Univer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VicKun4937 @wzhudev