Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slides): support partial slides function #2890

Merged
merged 9 commits into from
Jul 30, 2024
Merged

feat(slides): support partial slides function #2890

merged 9 commits into from
Jul 30, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Jul 30, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 349 lines in your changes missing coverage. Please review.

Project coverage is 27.45%. Comparing base (0de3488) to head (3f6b05f).
Report is 2 commits behind head on dev.

Files Patch % Lines
...slides-ui/src/controllers/popup-menu.controller.ts 0.00% 59 Missing ⚠️
packages/slides/src/views/render/canvas-view.ts 0.00% 41 Missing ⚠️
...des-ui/src/services/slide-popup-manager.service.ts 0.00% 38 Missing ⚠️
...src/components/image-popup-menu/ImagePopupMenu.tsx 0.00% 23 Missing ⚠️
.../src/commands/operations/insert-image.operation.ts 0.00% 20 Missing ⚠️
...i/src/commands/operations/insert-text.operation.ts 0.00% 18 Missing ⚠️
...s/slides-ui/src/controllers/slide-ui.controller.ts 0.00% 18 Missing ⚠️
packages/core/src/slides/slide-model.ts 0.00% 17 Missing ⚠️
...-ui/src/components/upload-component/UploadFile.tsx 0.00% 17 Missing ⚠️
.../src/commands/operations/insert-shape.operation.ts 0.00% 15 Missing ⚠️
... and 21 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2890      +/-   ##
==========================================
- Coverage   27.54%   27.45%   -0.10%     
==========================================
  Files        1806     1819      +13     
  Lines       95490    95803     +313     
  Branches    20550    20596      +46     
==========================================
- Hits        26301    26299       -2     
- Misses      69189    69504     +315     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 30, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@jikkai jikkai requested a review from Gggpound as a code owner July 30, 2024 11:58
@jikkai jikkai merged commit 3a90918 into dev Jul 30, 2024
9 checks passed
@jikkai jikkai deleted the feat/slide branch July 30, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants