Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: editing text and save #2929

Merged
merged 4 commits into from
Aug 6, 2024
Merged

feat: editing text and save #2929

merged 4 commits into from
Aug 6, 2024

Conversation

lumixraku
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 53 lines in your changes missing coverage. Please review.

Project coverage is 26.06%. Comparing base (4cda2fb) to head (b3491e8).
Report is 7 commits behind head on dev.

Files Patch % Lines
...ntrollers/slide-editor-bridge.render-controller.ts 0.00% 30 Missing ⚠️
...des-ui/src/services/slide-editor-bridge.service.ts 0.00% 19 Missing ⚠️
packages/engine-render/src/shape/rich-text.ts 0.00% 2 Missing ⚠️
...src/controllers/slide-editing.render-controller.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2929      +/-   ##
==========================================
- Coverage   27.16%   26.06%   -1.10%     
==========================================
  Files        1850     1896      +46     
  Lines       97516   101283    +3767     
  Branches    20838    21578     +740     
==========================================
- Hits        26486    26400      -86     
- Misses      71030    74883    +3853     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku marked this pull request as ready for review August 5, 2024 11:52
Copy link

github-actions bot commented Aug 5, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@lumixraku lumixraku merged commit 09a0832 into dev Aug 6, 2024
9 checks passed
@lumixraku lumixraku deleted the feat/addtext-slide branch August 6, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants