Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: selection is wrong when select table #2953

Merged
merged 1 commit into from
Aug 7, 2024
Merged

fix: selection is wrong when select table #2953

merged 1 commit into from
Aug 7, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Aug 7, 2024

close https://github.com/dream-num/univer-pro/issues/1972

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Jocs Jocs marked this pull request as ready for review August 7, 2024 07:31
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 26.16%. Comparing base (5b75469) to head (46154a6).
Report is 2 commits behind head on dev.

Files Patch % Lines
.../components/docs/text-selection/selection-utils.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2953      +/-   ##
==========================================
- Coverage   26.16%   26.16%   -0.01%     
==========================================
  Files        1904     1905       +1     
  Lines      101472   101479       +7     
  Branches    21652    21653       +1     
==========================================
  Hits        26549    26549              
- Misses      74923    74930       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 7, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Aug 7, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Aug 7, 2024
@Jocs Jocs merged commit b15b46b into dev Aug 7, 2024
13 checks passed
@Jocs Jocs deleted the fix/doc-selection branch August 7, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants