Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy paste between sheet and doc #2993

Merged
merged 3 commits into from
Aug 29, 2024
Merged

fix: copy paste between sheet and doc #2993

merged 3 commits into from
Aug 29, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Aug 9, 2024

close https://github.com/dream-num/univer-pro/issues/2006

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Jocs Jocs marked this pull request as ready for review August 9, 2024 08:31
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Aug 9, 2024
Copy link

github-actions bot commented Aug 9, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Aug 10, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Aug 10, 2024
@oumomomo
Copy link

复制本地的excel的公式示例粘贴到编辑器无法粘贴
image
image
image

@univer-bot
Copy link

univer-bot bot commented Aug 12, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Copying the local Excel formula example and pasting it into the editor cannot be pasted
image
image
image

@univer-bot univer-bot bot removed the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Aug 12, 2024
@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:rejected labels Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 28.55%. Comparing base (01fdcca) to head (1f51dbc).
Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
...es/docs-ui/src/controllers/clipboard.controller.ts 0.00% 3 Missing ⚠️
...ui/src/services/clipboard/html-to-udm/converter.ts 0.00% 3 Missing ⚠️
...docs-ui/src/commands/commands/clipboard.command.ts 0.00% 2 Missing ⚠️
...ges/sheets-ui/src/views/formula-bar/FormulaBar.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2993      +/-   ##
==========================================
- Coverage   28.57%   28.55%   -0.02%     
==========================================
  Files        2022     2022              
  Lines      106772   106823      +51     
  Branches    23103    23111       +8     
==========================================
+ Hits        30505    30506       +1     
- Misses      76267    76317      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs merged commit 617986d into dev Aug 29, 2024
9 checks passed
@Jocs Jocs deleted the fix/copy-paste-0 branch August 29, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants