Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slide editing scale #2999

Merged
merged 1 commit into from
Aug 9, 2024
Merged

fix: slide editing scale #2999

merged 1 commit into from
Aug 9, 2024

Conversation

lumixraku
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@lumixraku lumixraku force-pushed the fix/slide-editing-scale branch from 47c8536 to 9d94c13 Compare August 9, 2024 12:21
@lumixraku lumixraku force-pushed the fix/slide-editing-scale branch from 9d94c13 to 5bbccb5 Compare August 9, 2024 12:22
@lumixraku lumixraku marked this pull request as ready for review August 9, 2024 12:24
@lumixraku lumixraku requested a review from jikkai as a code owner August 9, 2024 12:24
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 26.11%. Comparing base (21d09eb) to head (5bbccb5).

Files Patch % Lines
...src/controllers/slide-editing.render-controller.ts 0.00% 18 Missing ⚠️
...es-ui/src/controllers/uni-slides-ui.controller.tsx 0.00% 2 Missing ⚠️
...ntrollers/slide-editor-bridge.render-controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2999      +/-   ##
==========================================
- Coverage   26.12%   26.11%   -0.01%     
==========================================
  Files        1906     1906              
  Lines      101778   101793      +15     
  Branches    21736    21736              
==========================================
  Hits        26585    26585              
- Misses      75193    75208      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 9, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 8017323 into dev Aug 9, 2024
9 checks passed
@wzhudev wzhudev deleted the fix/slide-editing-scale branch August 9, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants