-
-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sheets-data-validation): date data validation format not work & optimize popup-service #3018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View Deployment
|
…r into fix/date-data-validation
wzhudev
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code quality issues. It is not recommended to fix several bugs (especially of different features) in a single pull request. Please separate them for PRs in the future. :)
packages/sheets-thread-comment/src/services/sheets-thread-comment-popup.service.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close https://github.com/dream-num/univer-pro/issues/2060
close https://github.com/dream-num/univer-pro/issues/2048
close https://github.com/dream-num/univer-pro/issues/2046
close https://github.com/dream-num/univer-pro/issues/2045
close https://github.com/dream-num/univer-pro/issues/1478
close https://github.com/dream-num/univer-pro/issues/1467
close https://github.com/dream-num/univer-pro/issues/2068
close https://github.com/dream-num/univer-pro/issues/1499
close #3046
Pull Request Checklist