Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-data-validation): date data validation format not work & optimize popup-service #3018

Merged
merged 33 commits into from
Aug 14, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Aug 12, 2024

close https://github.com/dream-num/univer-pro/issues/2060
close https://github.com/dream-num/univer-pro/issues/2048
close https://github.com/dream-num/univer-pro/issues/2046
close https://github.com/dream-num/univer-pro/issues/2045
close https://github.com/dream-num/univer-pro/issues/1478
close https://github.com/dream-num/univer-pro/issues/1467
close https://github.com/dream-num/univer-pro/issues/2068
close https://github.com/dream-num/univer-pro/issues/1499
close #3046

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@weird94 weird94 requested a review from Gggpound as a code owner August 12, 2024 03:34
@weird94 weird94 changed the title fix: date data validation format not work fix(sheets-data-validation): date data validation format not work Aug 12, 2024
Copy link

github-actions bot commented Aug 12, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 5.00000% with 57 lines in your changes missing coverage. Please review.

Project coverage is 27.41%. Comparing base (2e475b3) to head (1993771).

Files Patch % Lines
...ages/ui/src/views/components/popup/CanvasPopup.tsx 0.00% 18 Missing ⚠️
...-hyper-link-ui/src/controllers/popup.controller.ts 0.00% 8 Missing ⚠️
...s-data-validation/src/validators/date-validator.ts 0.00% 6 Missing ⚠️
packages/docs/src/basics/replace.ts 16.66% 5 Missing ⚠️
...rc/services/sheets-thread-comment-popup.service.ts 0.00% 4 Missing ⚠️
...dation/src/models/sheet-data-validation-manager.ts 0.00% 3 Missing ⚠️
...controllers/doc-hyper-link-clipboard.controller.ts 0.00% 2 Missing ⚠️
...alidation/src/services/dropdown-manager.service.ts 0.00% 2 Missing ⚠️
...eets-ui/src/services/cell-alert-manager.service.ts 0.00% 2 Missing ⚠️
...a-validation/src/validators/base-data-validator.ts 0.00% 1 Missing ⚠️
... and 6 more
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3018   +/-   ##
=======================================
  Coverage   27.41%   27.41%           
=======================================
  Files        1978     1977    -1     
  Lines      104481   104475    -6     
  Branches    22560    22566    +6     
=======================================
  Hits        28645    28645           
+ Misses      75836    75830    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weird94 weird94 requested a review from wzhudev as a code owner August 12, 2024 06:52
@weird94 weird94 requested a review from yuhongz as a code owner August 12, 2024 09:23
@weird94 weird94 marked this pull request as draft August 12, 2024 12:56
@weird94 weird94 marked this pull request as ready for review August 13, 2024 07:42
@weird94 weird94 requested a review from DR-Univer as a code owner August 13, 2024 07:42
@weird94 weird94 requested a review from Jocs as a code owner August 13, 2024 07:42
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Aug 13, 2024
@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Aug 13, 2024
@weird94 weird94 requested a review from jikkai as a code owner August 13, 2024 09:35
@weird94 weird94 changed the title fix(sheets-data-validation): date data validation format not work fix(sheets-data-validation): date data validation format not work & optimize popup-service Aug 13, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code quality issues. It is not recommended to fix several bugs (especially of different features) in a single pull request. Please separate them for PRs in the future. :)

@weird94 weird94 merged commit 92dedd6 into dev Aug 14, 2024
10 checks passed
@weird94 weird94 deleted the fix/date-data-validation branch August 14, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Untranslated Chinese Text "编辑" in Data Validation Dropdown in Spreadsheets Demo
3 participants