Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filtered & hidden rows should not be calculated in statusbar #3026

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

yuhongz
Copy link
Contributor

@yuhongz yuhongz commented Aug 12, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Aug 12, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@yuhongz yuhongz requested a review from DR-Univer August 12, 2024 09:40
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 26.03%. Comparing base (8820862) to head (bebc9f7).
Report is 1 commits behind head on dev.

Files Patch % Lines
...sheets-ui/src/controllers/status-bar.controller.ts 0.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3026      +/-   ##
==========================================
- Coverage   26.03%   26.03%   -0.01%     
==========================================
  Files        1915     1915              
  Lines      102078   102090      +12     
  Branches    21790    21795       +5     
==========================================
  Hits        26580    26580              
- Misses      75498    75510      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev merged commit 803ced4 into dev Aug 12, 2024
9 checks passed
@wzhudev wzhudev deleted the yuhongz/fix-uni-problems branch August 12, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants