Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): move event bubbling prevention from "More" menu to button #3031

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Aug 12, 2024

close https://github.com/dream-num/univer-pro/issues/1569

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@jikkai jikkai requested a review from Jocs as a code owner August 12, 2024 12:53
Copy link

View Deployment

#10352282473

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

@jikkai jikkai changed the title refactor(ui): move event bubbling prevention from "More" menu to button fix(ui): move event bubbling prevention from "More" menu to button Aug 12, 2024
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 26.03%. Comparing base (19eb1dc) to head (4254eff).
Report is 7 commits behind head on dev.

Files Patch % Lines
...s/ui/src/views/components/doc-bars/ToolbarItem.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3031      +/-   ##
==========================================
- Coverage   26.03%   26.03%   -0.01%     
==========================================
  Files        1915     1915              
  Lines      102095   102096       +1     
  Branches    21797    21797              
==========================================
  Hits        26580    26580              
- Misses      75515    75516       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai removed the qa:untested This PR is ready to be tested label Aug 13, 2024
@jikkai jikkai merged commit e07e0c8 into dev Aug 13, 2024
10 checks passed
@jikkai jikkai deleted the fix/toolbar branch August 13, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant