Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unit param for slide cmd #3038

Merged
merged 3 commits into from
Aug 15, 2024
Merged

feat: add unit param for slide cmd #3038

merged 3 commits into from
Aug 15, 2024

Conversation

lumixraku
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Aug 13, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 121 lines in your changes missing coverage. Please review.

Project coverage is 27.49%. Comparing base (9ce3f8d) to head (4130bf4).
Report is 6 commits behind head on dev.

Files Patch % Lines
...ides-ui/src/controllers/slide.render-controller.ts 0.00% 41 Missing ⚠️
packages/slides-ui/src/controllers/canvas-view.ts 0.00% 16 Missing ⚠️
...src/controllers/slide-editing.render-controller.ts 0.00% 9 Missing ⚠️
...ntrollers/slide-editor-bridge.render-controller.ts 0.00% 9 Missing ⚠️
...s-ui/src/commands/operations/activate.operation.ts 0.00% 6 Missing ⚠️
...i/src/commands/operations/insert-text.operation.ts 0.00% 6 Missing ⚠️
.../src/commands/operations/append-slide.operation.ts 0.00% 5 Missing ⚠️
.../src/commands/operations/insert-shape.operation.ts 0.00% 5 Missing ⚠️
.../src/commands/operations/insert-image.operation.ts 0.00% 4 Missing ⚠️
...rc/commands/operations/delete-element.operation.ts 0.00% 3 Missing ⚠️
... and 9 more
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3038   +/-   ##
=======================================
  Coverage   27.49%   27.49%           
=======================================
  Files        1979     1979           
  Lines      104689   104675   -14     
  Branches    22586    22589    +3     
=======================================
  Hits        28780    28780           
+ Misses      75909    75895   -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku force-pushed the feat/slide-dep branch 4 times, most recently from 55732b4 to d2b52da Compare August 14, 2024 02:36
@lumixraku lumixraku marked this pull request as ready for review August 14, 2024 02:38
@wzhudev wzhudev merged commit 1d1d59c into dev Aug 15, 2024
9 checks passed
@wzhudev wzhudev deleted the feat/slide-dep branch August 15, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants