Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-data-validation): date dropdown display error on invalid value #3055

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Aug 14, 2024

close #3053

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Aug 14, 2024
Copy link

github-actions bot commented Aug 14, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 27.48%. Comparing base (bd91317) to head (e51c2ec).
Report is 1 commits behind head on dev.

Files Patch % Lines
...-data-validation/src/views/date-dropdown/index.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3055      +/-   ##
==========================================
+ Coverage   27.41%   27.48%   +0.07%     
==========================================
  Files        1977     1979       +2     
  Lines      104477   104689     +212     
  Branches    22568    22585      +17     
==========================================
+ Hits        28639    28774     +135     
- Misses      75838    75915      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai removed the qa:untested This PR is ready to be tested label Aug 14, 2024
@jikkai jikkai merged commit 2e89983 into dev Aug 14, 2024
9 checks passed
@jikkai jikkai deleted the fix/date-picker-dropdown branch August 14, 2024 08:44
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Time selection display error
2 participants