Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): tab in table #3064

Merged
merged 4 commits into from
Aug 16, 2024
Merged

feat(docs): tab in table #3064

merged 4 commits into from
Aug 16, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Aug 14, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Jocs Jocs marked this pull request as ready for review August 14, 2024 13:25
Copy link

github-actions bot commented Aug 14, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 3.26087% with 89 lines in your changes missing coverage. Please review.

Project coverage is 27.44%. Comparing base (7d0b87e) to head (e4a66dc).
Report is 2 commits behind head on dev.

Files Patch % Lines
packages/docs/src/commands/commands/table/table.ts 6.38% 44 Missing ⚠️
...c/commands/commands/table/doc-table-tab.command.ts 0.00% 30 Missing ⚠️
...s-ui/src/controllers/doc-auto-format.controller.ts 0.00% 13 Missing ⚠️
...kages/docs/src/services/doc-auto-format.service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3064      +/-   ##
==========================================
- Coverage   27.45%   27.44%   -0.02%     
==========================================
  Files        1981     1980       -1     
  Lines      104830   104887      +57     
  Branches    22624    22644      +20     
==========================================
+ Hits        28784    28787       +3     
- Misses      76046    76100      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs added the qa:untested This PR is ready to be tested label Aug 15, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Aug 15, 2024
@oumomomo
Copy link

在跨页的table最后一个单元格使用tab键,不会跳到第二页的单元格而是新增一行
2024_8_15 14_34_48 video.webm
企业微信截图_17237038221867

@univer-bot
Copy link

univer-bot bot commented Aug 15, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

If you use the tab key in the last cell of a cross-page table, it will not jump to the cell on the second page but will add a new row.
2024_8_15 14_34_48 video.webm
Enterprise WeChat screenshot_17237038221867

@Jocs Jocs added qa:untested This PR is ready to be tested and removed qa:rejected labels Aug 15, 2024
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Aug 16, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Aug 16, 2024
@Jocs Jocs merged commit 39ce155 into dev Aug 16, 2024
9 checks passed
@Jocs Jocs deleted the feat/tab-in-table branch August 16, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants