Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update drawing panel state at end of changing #3069

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

siam-ese
Copy link
Contributor

close #2928

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@siam-ese siam-ese requested a review from jikkai August 15, 2024 07:34
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Aug 15, 2024
Copy link

github-actions bot commented Aug 15, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 27.49%. Comparing base (1d1d59c) to head (2cc1033).
Report is 12 commits behind head on dev.

Files Patch % Lines
...es/drawing-ui/src/views/panel/DrawingTransform.tsx 0.00% 28 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3069   +/-   ##
=======================================
  Coverage   27.48%   27.49%           
=======================================
  Files        1979     1979           
  Lines      104686   104687    +1     
  Branches    22592    22592           
=======================================
+ Hits        28770    28780   +10     
+ Misses      75916    75907    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Aug 15, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Aug 15, 2024
@jikkai jikkai merged commit 3a5635f into dev Aug 16, 2024
9 checks passed
@jikkai jikkai deleted the fix/drawing-panel-state branch August 16, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
3 participants