Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): disable some menu items when no selections #3094

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Aug 16, 2024

close https://github.com/dream-num/univer-pro/issues/1737

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Jocs Jocs marked this pull request as ready for review August 16, 2024 08:04
@Jocs Jocs requested a review from jikkai as a code owner August 16, 2024 08:04
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Aug 16, 2024
Copy link

github-actions bot commented Aug 16, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 27.45%. Comparing base (7d0b87e) to head (0c546ed).
Report is 2 commits behind head on dev.

Files Patch % Lines
packages/docs-ui/src/controllers/menu/menu.ts 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3094      +/-   ##
==========================================
- Coverage   27.45%   27.45%   -0.01%     
==========================================
  Files        1981     1981              
  Lines      104830   104843      +13     
  Branches    22624    22626       +2     
==========================================
  Hits        28784    28784              
- Misses      76046    76059      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Aug 16, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Aug 16, 2024
@Jocs Jocs merged commit 07a24cb into dev Aug 16, 2024
13 checks passed
@Jocs Jocs deleted the fix/disable-menu branch August 16, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants