Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): line space between image and line #3101

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Aug 17, 2024

close https://github.com/dream-num/univer-pro/issues/1782 and https://github.com/dream-num/univer-pro/issues/1777

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Jocs Jocs marked this pull request as ready for review August 17, 2024 05:22
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Aug 17, 2024
Copy link

github-actions bot commented Aug 17, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 27.44%. Comparing base (9697d87) to head (0c56751).
Report is 4 commits behind head on dev.

Files Patch % Lines
...onents/docs/layout/block/paragraph/layout-ruler.ts 0.00% 14 Missing ⚠️
...ages/engine-render/src/components/docs/document.ts 0.00% 6 Missing ⚠️
...gine-render/src/components/docs/extensions/line.ts 0.00% 5 Missing ⚠️
...ckages/engine-render/src/components/docs/liquid.ts 0.00% 4 Missing ⚠️
...mponents/docs/text-selection/convert-text-range.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3101      +/-   ##
==========================================
+ Coverage   27.43%   27.44%   +0.01%     
==========================================
  Files        1980     1980              
  Lines      104895   104893       -2     
  Branches    22644    22644              
==========================================
+ Hits        28777    28787      +10     
+ Misses      76118    76106      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Aug 17, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Aug 17, 2024
@Jocs Jocs merged commit 32915ff into dev Aug 17, 2024
13 checks passed
@Jocs Jocs deleted the fix/space-between-image-line branch August 17, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants