Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filter): add facade API and docs #3103

Merged
merged 9 commits into from
Aug 18, 2024
Merged

feat(filter): add facade API and docs #3103

merged 9 commits into from
Aug 18, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Aug 17, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Aug 17, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 82.53968% with 22 lines in your changes missing coverage. Please review.

Project coverage is 27.48%. Comparing base (736cb9b) to head (6726ada).
Report is 2 commits behind head on dev.

Files Patch % Lines
...s/sheets-filter-ui/src/filter-ui-desktop.plugin.ts 0.00% 7 Missing ⚠️
...-ui/src/commands/commands/sheets-filter.command.ts 92.30% 5 Missing ⚠️
...es/sheets-filter-ui/src/filter-ui-mobile.plugin.ts 0.00% 4 Missing ⚠️
packages/sheets-filter/src/plugin.ts 0.00% 2 Missing ⚠️
...controllers/sheets-filter-permission.controller.ts 0.00% 1 Missing ⚠️
...controllers/sheets-filter-ui-desktop.controller.ts 0.00% 1 Missing ⚠️
.../controllers/sheets-filter-ui-mobile.controller.ts 0.00% 1 Missing ⚠️
...filter/src/controllers/sheets-filter.controller.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3103      +/-   ##
==========================================
+ Coverage   27.44%   27.48%   +0.04%     
==========================================
  Files        1979     1980       +1     
  Lines      104893   104966      +73     
  Branches    22643    22653      +10     
==========================================
+ Hits        28788    28851      +63     
- Misses      76105    76115      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev changed the title refactor(filter): optimize filter structure feat(filter): add facade API and docs Aug 17, 2024
@wzhudev wzhudev marked this pull request as ready for review August 18, 2024 06:52
@wzhudev wzhudev merged commit dc37071 into dev Aug 18, 2024
9 checks passed
@wzhudev wzhudev deleted the refactor/filter-blog branch August 18, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants