-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs-ui): link & checklist can't work on header-footer #3107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weird94
requested review from
jikkai,
Jocs,
DR-Univer and
lumixraku
as code owners
August 17, 2024 11:11
View Deployment
|
wzhudev
requested changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The solution looks good to me. Some code quality issues need to be resolved.
packages/docs-hyper-link-ui/src/commands/operations/popup.operation.ts
Outdated
Show resolved
Hide resolved
.../docs-hyper-link-ui/src/controllers/render-controllers/hyper-link-event.render-controller.ts
Show resolved
Hide resolved
weird94
changed the title
feat: refactor doc-hover-manager-service
fix(docs-ui): link & checklist can't work on header-footer
Aug 19, 2024
oumomomo
added
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
and removed
qa:rejected
labels
Aug 22, 2024
wzhudev
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close https://github.com/dream-num/univer-pro/issues/2116
close https://github.com/dream-num/univer-pro/issues/1998
close https://github.com/dream-num/univer-pro/issues/1462
close https://github.com/dream-num/univer-pro/issues/1779
Pull Request Checklist