Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs-ui): link & checklist can't work on header-footer #3107

Merged
merged 48 commits into from
Aug 22, 2024
Merged

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Aug 17, 2024

close https://github.com/dream-num/univer-pro/issues/2116
close https://github.com/dream-num/univer-pro/issues/1998
close https://github.com/dream-num/univer-pro/issues/1462
close https://github.com/dream-num/univer-pro/issues/1779

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Aug 17, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 1.47059% with 402 lines in your changes missing coverage. Please review.

Project coverage is 27.46%. Comparing base (79a8070) to head (47c7a49).
Report is 18 commits behind head on dev.

Files Patch % Lines
.../docs-ui/src/services/doc-event-manager.service.ts 0.00% 168 Missing ⚠️
.../docs-ui/src/services/doc-popup-manager.service.ts 0.00% 35 Missing ⚠️
...-controllers/hyper-link-event.render-controller.ts 0.00% 33 Missing ⚠️
...link-ui/src/commands/operations/popup.operation.ts 0.00% 26 Missing ⚠️
...-hyper-link-ui/src/views/hyper-link-edit/index.tsx 0.00% 25 Missing ⚠️
packages/docs/src/basics/custom-range-factory.ts 0.00% 13 Missing ⚠️
...nk-ui/src/commands/commands/update-link.command.ts 0.00% 12 Missing ⚠️
...ervices/doc-interceptor/doc-interceptor.service.ts 0.00% 12 Missing ⚠️
...r-link-ui/src/services/hyper-link-popup.service.ts 0.00% 10 Missing ⚠️
...mment-ui/src/views/thread-comment-editor/index.tsx 0.00% 9 Missing ⚠️
... and 17 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3107      +/-   ##
==========================================
- Coverage   27.49%   27.46%   -0.03%     
==========================================
  Files        1979     1981       +2     
  Lines      104958   105361     +403     
  Branches    22650    22730      +80     
==========================================
+ Hits        28854    28935      +81     
- Misses      76104    76426     +322     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution looks good to me. Some code quality issues need to be resolved.

@weird94 weird94 marked this pull request as draft August 19, 2024 07:09
@weird94 weird94 marked this pull request as ready for review August 19, 2024 09:49
@weird94 weird94 changed the title feat: refactor doc-hover-manager-service fix(docs-ui): link & checklist can't work on header-footer Aug 19, 2024
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Aug 19, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Aug 20, 2024
@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:rejected labels Aug 22, 2024
@weird94 weird94 merged commit 106e7c4 into dev Aug 22, 2024
9 checks passed
@weird94 weird94 deleted the feat/doc-hover branch August 22, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants