-
-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs-hyper-link): hyper link refactor #3148
Conversation
页眉内输入内容设置超链接勾选首页不同,点击第二页的编辑不展示面板 |
Enter the content in the header to set the hyperlink and check the first page. Click the edit button on the second page to not display the panel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR seems introducing a huge break change into the doc system. I would like to know the following before continue reviewing the code.
- What's the plan to deal with the legacy resources in old snapshots? Will they are lost?
- What users have to change in their code? Are there any breaking changes not documented in the commit messages?
And this PR's title seems no accurate as not only the hyper link feature was refactored.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
close https://github.com/dream-num/univer-pro/issues/2156
Pull Request Checklist