Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs-hyper-link): hyper link refactor #3148

Merged
merged 83 commits into from
Sep 2, 2024
Merged

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Aug 22, 2024

close https://github.com/dream-num/univer-pro/issues/2156

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@oumomomo
Copy link

oumomomo commented Aug 22, 2024

页眉内输入内容设置超链接勾选首页不同,点击第二页的编辑不展示面板
image
2024_8_22 17_04_24 video.webm

@univer-bot
Copy link

univer-bot bot commented Aug 22, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Enter the content in the header to set the hyperlink and check the first page. Click the edit button on the second page to not display the panel.
image
2024_8_22 17_04_24 video.webm

@oumomomo oumomomo assigned oumomomo and unassigned oumomomo Aug 23, 2024
@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge scope:data validation labels Aug 23, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems introducing a huge break change into the doc system. I would like to know the following before continue reviewing the code.

  • What's the plan to deal with the legacy resources in old snapshots? Will they are lost?
  • What users have to change in their code? Are there any breaking changes not documented in the commit messages?

And this PR's title seems no accurate as not only the hyper link feature was refactored.

@weird94
Copy link
Contributor Author

weird94 commented Aug 23, 2024

This PR seems introducing a huge break change into the doc system. I would like to know the following before continue reviewing the code.

  • What's the plan to deal with the legacy resources in old snapshots? Will they are lost?
  • What users have to change in their code? Are there any breaking changes not documented in the commit messages?

And this PR's title seems no accurate as not only the hyper link feature was refactored.

  1. This change is compatible with the old snapshot, DocHyperLinkResourceController will load links from snapshot and sync to custom-ranges.
  2. User need't to change their code, relative commands are compatible.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weird94 weird94 merged commit f21ce50 into dev Sep 2, 2024
9 checks passed
@weird94 weird94 deleted the feat/hyper-link-refactor branch September 2, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants