Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-drawing-ui): float-dom-layer position not correct on sheets and uni mode #3152

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Aug 22, 2024

close #3127

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@weird94 weird94 requested review from jikkai and Jocs as code owners August 22, 2024 06:31
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Aug 22, 2024
@weird94 weird94 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Aug 22, 2024
Copy link

github-actions bot commented Aug 22, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@weird94 weird94 changed the title fix(sheets-drawing-ui): float-dom-layer position error on sheets and uni mode fix(sheets-drawing-ui): float-dom-layer position not correct on sheets and uni mode Aug 22, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weird94 weird94 merged commit 4e434b0 into dev Aug 22, 2024
10 checks passed
@weird94 weird94 deleted the fix/float-dom-position branch August 22, 2024 06:38
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev@1182a9e). Learn more about missing BASE report.
Report is 2 commits behind head on dev.

Files Patch % Lines
packages/ui/src/views/components/dom/FloatDom.tsx 0.00% 5 Missing ⚠️
...uniui/src/controllers/uniui-desktop.controller.tsx 0.00% 1 Missing ⚠️
...imental/uniui/src/views/workbench/UniWorkbench.tsx 0.00% 1 Missing ⚠️
...i/src/services/canvas-float-dom-manager.service.ts 0.00% 1 Missing ⚠️
packages/ui/src/services/parts/parts.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev    #3152   +/-   ##
======================================
  Coverage       ?   27.66%           
======================================
  Files          ?     1984           
  Lines          ?   105368           
  Branches       ?    22754           
======================================
  Hits           ?    29155           
  Misses         ?    76213           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
2 participants