Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): no need to scroll when enter zen mode #3222

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Aug 28, 2024

close https://github.com/dream-num/univer-pro/issues/1138

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Jocs Jocs marked this pull request as ready for review August 28, 2024 04:42
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Aug 28, 2024
Copy link

github-actions bot commented Aug 28, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 28.56%. Comparing base (01fdcca) to head (d3b4bb4).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...editor/src/commands/commands/zen-editor.command.ts 0.00% 8 Missing ⚠️
...en-editor/src/controllers/zen-editor.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3222      +/-   ##
==========================================
- Coverage   28.57%   28.56%   -0.01%     
==========================================
  Files        2022     2022              
  Lines      106772   106780       +8     
  Branches    23103    23104       +1     
==========================================
  Hits        30505    30505              
- Misses      76267    76275       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7
Copy link

@Jocs 好像还是会记住上次的位置,路径:1、进入禅模式,向下滑动 2、退出禅模式 3、再次进入禅模式
2024_8_29 11_21_50 commands.json
2024_8_29 11_21_50 video.webm

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Aug 29, 2024
@univer-bot
Copy link

univer-bot bot commented Aug 29, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@Jocs It seems that it will still remember the last position. Path: 1. Enter Zen mode and slide down. 2. Exit Zen mode. 3. Enter Zen mode again.
2024_8_29 11_21_50 commands.json
2024_8_29 11_21_50 video.webm

@Jocs Jocs added qa:untested This PR is ready to be tested and removed qa:rejected labels Aug 29, 2024
@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Aug 29, 2024
@Jocs Jocs merged commit 1ebbe27 into dev Aug 29, 2024
8 checks passed
@Jocs Jocs deleted the fix/zen-editor-position branch August 29, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants