Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pivot): fix scroll height & add hooks to format paint #3224

Merged
merged 5 commits into from
Aug 28, 2024
Merged

feat(pivot): fix scroll height & add hooks to format paint #3224

merged 5 commits into from
Aug 28, 2024

Conversation

VicKun4937
Copy link
Contributor

  • fix scroll height to be a interger
  • add before apply format hooks

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@codecov Codecov
Copy link

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 28.63%. Comparing base (1899d34) to head (6fd3368).
Report is 1 commits behind head on dev.

Files Patch % Lines
.../services/format-painter/format-painter.service.ts 78.94% 4 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #3224   +/-   ##
=======================================
  Coverage   28.63%   28.63%           
=======================================
  Files        2025     2025           
  Lines      106972   106979    +7     
  Branches    23130    23134    +4     
=======================================
+ Hits        30629    30633    +4     
- Misses      76343    76346    +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yuhongz
yuhongz reviewed Aug 28, 2024
View reviewed changes
packages/sheets-ui/src/services/format-painter/format-painter.service.ts Outdated
@@ -68,6 +79,7 @@ export class FormatPainterService extends Disposable implements IFormatPainterSe
private readonly _status$: BehaviorSubject<FormatPainterStatus>;
private _defaultHook: IFormatPainterHook | null = null;
private _extendHooks: IFormatPainterHook[] = [];
private _beforeApplyHooks: IFormatPainterBeforeApplyHook[] = [];
Copy link
Contributor

@yuhongz yuhongz Aug 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beforeApply 是否放在原有的IFormatPainterHook里更会好？ 和onApply平级，这样和其他的 hook 的设计方式是一致的。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

似乎不可以，因为功能不一样， 这个是阻止执行的， 原先的hook 会sort

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has fixed

yuhongz
yuhongz approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@yuhongz yuhongz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VicKun4937 VicKun4937 merged commit 84e8c89 into dev Aug 28, 2024
9 checks passed
@VicKun4937 VicKun4937 deleted the feat-pivot-adjust branch August 28, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuhongz yuhongz yuhongz approved these changes

@jikkai jikkai Awaiting requested review from jikkai jikkai is a code owner

@wzhudev wzhudev Awaiting requested review from wzhudev wzhudev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VicKun4937 @yuhongz